Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PollWatcher panic after delete-and-recreate #406

Merged
merged 1 commit into from
May 18, 2022

Conversation

visig9
Copy link
Contributor

@visig9 visig9 commented May 18, 2022

See #359 for more detail.

Fix #359

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Copy link
Member

@0xpr03 0xpr03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Could you add a comment for that match case why this is required ?

@visig9
Copy link
Contributor Author

visig9 commented May 18, 2022

Added comments at some relevant locations. hope this helps :)

@0xpr03 0xpr03 merged commit 6a9fb7a into notify-rs:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PollWatcher panics if a watched file is removed and recreated.
3 participants